feat: add image container for compatibility #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
NYeonK
reviewed
Mar 11, 2023
Comment on lines
+28
to
+31
| <picture key={index}> | ||
| <source srcSet={img.src} type="image/webp" /> | ||
| <St.ImageWrapper src={img.subSrc} alt={img.alt} loading="lazy" /> | ||
| </picture> |
There was a problem hiding this comment.
wepb 안될 때, png가 뜨는 거구낭~!~!!
<picture>이랑 <source> 처음 알아갑니다!!👀👀
There was a problem hiding this comment.
webp 파일이 여러개 있는데, banner에만 적용하는 이유가 있을까요?-?
There was a problem hiding this comment.
우선적으로 webp의 호환성 문제가 크지 않기 때문에(우리가 타겟으로 하는 대부분의 디바이스에서 지원을 하기 떄문에) 하나하나 세밀하게 대응할 필요는 없다고 느꼈어요,
더불어서 다른 배너들은 background-image로 되어있어서, 더 찾아보니 image-set 이라는 것이 있네요 !! 이거 반영하도록 하겠습니다✨✨
joohaem
force-pushed
the
feat/#219-image_container
branch
from
8e5ab95 to
c822142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
picture,source태그로 png 파일을 예비로 정의해놓습니다.