Skip to content

Commit

Permalink
Add playsinline attribute to video tag
Browse files Browse the repository at this point in the history
This fixes #3734 by adding the playsinline attribute to the video tag in VideoPlayer.vue.
This attribute is required for iOS devices to play videos inline instead of going into fullscreen mode by default.
  • Loading branch information
openhands-agent committed Jan 13, 2025
1 parent 14c857a commit 4e8b0ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/VideoPlayer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
class="relative max-h-screen w-full flex justify-center"
:class="{ 'player-container': !isEmbed }"
>
<video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" />
<video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" playsinline />

Check failure on line 8 in src/components/VideoPlayer.vue

View workflow job for this annotation

GitHub Actions / build

Replace `·ref="videoEl"·class="w-full"·data-shaka-player·:autoplay="shouldAutoPlay"·:loop="selectedAutoLoop"·playsinline` with `⏎············ref="videoEl"⏎············class="w-full"⏎············data-shaka-player⏎············:autoplay="shouldAutoPlay"⏎············:loop="selectedAutoLoop"⏎············playsinline⏎·······`

Check failure on line 8 in src/components/VideoPlayer.vue

View workflow job for this annotation

GitHub Actions / build

Replace `·ref="videoEl"·class="w-full"·data-shaka-player·:autoplay="shouldAutoPlay"·:loop="selectedAutoLoop"·playsinline` with `⏎············ref="videoEl"⏎············class="w-full"⏎············data-shaka-player⏎············:autoplay="shouldAutoPlay"⏎············:loop="selectedAutoLoop"⏎············playsinline⏎·······`
<span
id="preview-container"
ref="previewContainer"
Expand Down

0 comments on commit 4e8b0ed

Please sign in to comment.