Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The TF Portal Issue List #1459

Closed
GizmoTheMoonPig opened this issue Mar 23, 2022 · 12 comments
Closed

The TF Portal Issue List #1459

GizmoTheMoonPig opened this issue Mar 23, 2022 · 12 comments

Comments

@GizmoTheMoonPig
Copy link
Member

GizmoTheMoonPig commented Mar 23, 2022

Twilight Forest portals currently have quite a few issues, and I think it would be good to have a singular issue that describes all of the issues people have with them for easier fixing later. Please comment more issues if you don't see them here!

Current known issues:

  • Portals will sometimes attempt to spawn in locked biomes, and that's not a good thing. We try to redirect portals out of these locked biomes and into safe ones. However, portal redirection sometimes puts portals really far from where they would originally go. This leads to a couple issues:
    • Returning from TF will create a new portal, often really far from your original.
    • Re-entering TF from the original portal will spawn a new portal, often times in a locked biome.
  • If a portal attempts to spawn in the thornlands/plateau, it will spawn underground in a small box.
@Tamaized
Copy link
Member

Spawning in locked biomes happens when the teleporter fails to find a safe area

@Tamaized
Copy link
Member

One thing to think about is we know where Key Biomes generally are in a 2048x Magic Map space. We can use this to our advantage and precalculate Teleporters to move towards the center of a Magic Map area before running all the safety checks.

@SodiumZH
Copy link

The portal may also generate inside a Naga Courtyard.

@PraseodymiumSpike
Copy link

I have a portal on the Official Twilight Forest Server that links to a body of Water in the Overworld. If you go into the portal, and there isn't one on the other side, it sometimes drops you into the Water without generating a return portal in the same spot. This isn't a big issue as I have a return portal nearby, but I thought it was worth mentioning. Note that I find the return portal in the middle of the Water ugly, so I usually break it if it spawns when I go through. If the portal in the water was still there, presumably, it would work as intended.

@Thunderrock424242
Copy link

is this ever gonna be fixed in 1.16.5?

@GizmoTheMoonPig
Copy link
Member Author

1.16 is no longer receiving updates. This will be fixed in whatever version we're able to get to it

@GizmoTheMoonPig GizmoTheMoonPig pinned this issue Jan 26, 2023
@Tamaized
Copy link
Member

Tamaized commented Feb 6, 2023

Portals will now retain links on world restarts
e44f07d

Portals no longer spawn inside of structures when the dimension is first generated from traveling through the portal for the first time
2b5cd9e

@Tamaized
Copy link
Member

Tamaized commented Feb 6, 2023

Actually after closer investigation it turns out linkage is COMPLETELY BROKEN.

I've discovered that wrong block positions are being passed around all over the place.

Handled in 9e4f5fe, needs testing however.

@Tamaized
Copy link
Member

Tamaized commented Feb 8, 2023

Teleporters now move towards the center of a magic map area as needed.
f8e4a38

@Tamaized
Copy link
Member

Tamaized commented Feb 9, 2023

I've ironed out every thing I can think of with portal problems. I believe I can safely close this now.

@Tamaized Tamaized closed this as completed Feb 9, 2023
@AnkarraKM
Copy link

My Portal spawns in a restricted area. I play in the 1.19.3 version. Is there something I can do to fix this or will I have to move the portal?

Thanks in advance.

@mapyDayton22
Copy link

I made a portal and I went through it and entered the Twilight Forest. When I went back through the portal, it sends me 1000 blocks away from my original portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants