[1.21.1] Cumulus Compatibility Example #2308
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made for Drullkus; this PR has an example of how compatibility with Cumulus can be added, featuring the class for registering the menu, and placeholder selections for menu music, panorama screenshots, and menu icon.
This PR is only a draft that's more intended to be used as reference for eventual implementation, since Twilight Forest is currently in the middle of porting to a newer version than 1.21.1, there's not an official title screen yet, Cumulus isn't ported past 1.21.1 yet, and the 2.0.0 version of Cumulus that'll have these changes also isn't released nor is on maven yet, so there's a lot of WIP factors to this.