fix(xAxis): minor ticks depending on interval #43377043 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmmelstron
reviewed
Dec 28, 2024
lmmelstron
reviewed
Dec 28, 2024
lmmelstron
reviewed
Dec 28, 2024
lmmelstron
requested changes
Dec 28, 2024
There was a problem hiding this comment.
interval, судя по коду, не обязан быть временным, поэтому прописывать в нём логику вложенных тиков на основе времени кажется неправильным.
Необходимо проверить, и, если это действительно так, перенести логику в Time.
Так же есть пара комментариев по оптимизации кода
rekilina
requested changes
Jan 13, 2025
| export const ONE_YEAR = ONE_DAY * 365; | ||
| export const ONE_LEAP_YEAR = ONE_DAY * 366; |
There was a problem hiding this comment.
Зачем нужно вводить високосный год? при расчете числа делений все равно используется ceil, и кажется, что разницы нет
There was a problem hiding this comment.
между високосным и невисокосным годами интервал больше, поэтому Math.ceil(interval / period) будет > 1, то есть между ними появляется лишний minor tick
aspectie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Карточки в Kaiten:
https://techaudit.kaiten.ru/43377043
Причина бага: количество минорных делений берется дефолтное 5, что никак не соотносится с величиной промежутка между двумя значениями.
Решение: в зависимости от длины промежутка вычислять количество делений в разных масштабах (часы, дни, месяцы и тд)