Fix: Make second parameter of Mat.ucharPtr optional #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Mat.ucharPtr
method's second parameterj
should be optional to support getting row data by passing only the row index, as indicated in the TypeScript method signature and OpenCV documentation.Problem:
The current type definition required both parameters:
This prevented developers from calling
ucharPtr
with just a row index to get a pointer to the entire row, which is a valid and commonly used pattern in OpenCV.Solution:
Made the second parameter optional:
Usage:
This change makes the TypeScript definitions consistent with the actual OpenCV.js implementation and allows the more flexible usage pattern that developers expect.
Fixes #82.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.