Wedding site - Final project Web Dev Bootcamp spring 2024 - Nathalie & Sofia #60
Conversation
…oved to Section folder
…to ft-fe-hp and add forms plugin
…ero + fix with foodchoice missing in fetch
… src. Edited READMEs
sofia32057
changed the title
There was a problem hiding this comment.
Hi Nathalie and Sofia and congratulations to completing this final project ⭐ I think the visuals of this project is what stands out. I know you struggled with some design choices but I think you really made it work in the end - it looks really good! The carousel, the FAQ, the parallax, the fonts, everything feels like it fits well together.
You've followed the requirements so I will approve your project, but please have a look at the comments I wrote to clean up, refactor and enhance this project. Apart from my comments I also want to mention something I noticed in lighthouse; that your Performance score is only at 75 and Best practices score is only at 74. I'd recommend you to get both of these up to a 90 at least, so have a look when you have time.
Keep up the good work and good luck in the future! 👋
|
|
||
| - This is a custom built website for this specific couple - not a "build your own wedding site" template. It will not have back office functionality, such as to upload/change content. This is managed in the code. | ||
| - Likewise, the guest list is managed in the database and the website will not include functionality to upload or handle the list client side. |
There was a problem hiding this comment.
Smart to include this in the readme 👍
| speech: { | ||
| isAllowed: { | ||
| type: Boolean, | ||
| }, | ||
| willMakeSpeech: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, |
There was a problem hiding this comment.
This doesn't update when I check the box, is it because I'm not allowed as a tester? Maybe you'd want to change that so testers can test everything 🤓
There was a problem hiding this comment.
It should update! Must be a bug. We'll have a look and fix it :)
| const guests = await Guest.find( | ||
| {}, | ||
| "firstname lastname relation willAttend plusOne speech" | ||
| ); |
There was a problem hiding this comment.
Why not include the thoughts in your backend as well? 👀
There was a problem hiding this comment.
Time constraints - it's for sure on the To-do!
| "dependencies": { | ||
| "@headlessui/react": "^2.0.4", | ||
| "@heroicons/react": "^2.1.3", | ||
| "@tailwindcss/forms": "^0.5.7", | ||
| "moment": "^2.30.1", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" | ||
| "react-dom": "^18.2.0", | ||
| "react-lazily": "^0.9.2", | ||
| "react-router-dom": "^6.23.1", | ||
| "react-router-hash-link": "^2.4.3", | ||
| "react-scroll-parallax": "^3.4.5", | ||
| "react-scroll-to-top": "^3.0.0", | ||
| "react-slick": "^0.30.2", | ||
| "slick-carousel": "^1.8.1", | ||
| "zustand": "^4.5.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^18.2.15", | ||
| "@types/react-dom": "^18.2.7", | ||
| "@vitejs/plugin-react": "^4.0.3", | ||
| "autoprefixer": "^10.4.19", | ||
| "eslint": "^8.45.0", | ||
| "eslint-plugin-react": "^7.32.2", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| "eslint-plugin-react-refresh": "^0.4.3", | ||
| "vite": "^4.4.5" | ||
| "postcss": "^8.4.38", | ||
| "prettier": "^3.2.5", | ||
| "prettier-plugin-tailwindcss": "^0.5.14", | ||
| "tailwindcss": "^3.4.3", | ||
| "vite": "^5.2.11" | ||
| } |
There was a problem hiding this comment.
Would be nice if you'd include some information about these dependencies in your readme 👀
| import CoupleImage from "/pexels-sandeep-malith-97607821-9361349.webp"; | ||
| import CoupleImage2 from "/pexels-asadphoto-1024984.webp"; | ||
|
|
||
| export const FishtankSection = () => { |
There was a problem hiding this comment.
Is this a common saying that I've missed 😅
| export const Footer = () => { | ||
| return ( | ||
| <div className="flex flex-col items-end justify-end gap-6 px-6 py-5 text-right text-sm md:flex-row "> | ||
| {/* <Button label={"RSVP"} type={"link"} style={"primary"} href={"/rsvp"} /> */} | ||
| <p className="font-cormorant"> | ||
| ©2024 created by{" "} | ||
| <a href="https://sofias-portfolio.netlify.app/">Sofia</a> &{" "} | ||
| <a href="https://portfolio-nathalie.netlify.app/">Nathalie</a> | ||
| </p> | ||
| </div> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
The footer is covered by the "Up top"-arrow. And please make links open in a new tab
| const API_ENDPOINT = | ||
| "https://project-happy-thoughts-api-4mf8.onrender.com/thoughts"; |
There was a problem hiding this comment.
You could have endpoints and such as env variables
Login info
[email protected]
secretwedding
Netlify link
https://project-wedding-site.netlify.app/
Collaborators
[ohitsnathalie]