Happy Thoughts App - Jenny A #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Oct 31, 2024
Comment on lines
+2
to
+5
| import './index.css'; | ||
| import { ListThoughts } from "./components/ListThoughts"; | ||
| import { SubmitThought } from './components/SubmitThought'; | ||
| import { useState, useEffect } from 'react'; |
There was a problem hiding this comment.
Imports are usually grouped in this order:
// React and core libraries
// Third-party libraries
// Custom hooks and utilities
// Components
// Assets (icons, images, and styles)
src/App.jsx
Outdated
Comment on lines
17
to
23
| useEffect(() => { | ||
| fetch('https://happy-thoughts-ux7hkzgmwa-uc.a.run.app/thoughts') | ||
| .then((res) => res.json()) | ||
| .then((json) => { | ||
| setThoughts(json); | ||
| }); | ||
| }, []); |
There was a problem hiding this comment.
Some error handling would be nice 👀
src/components/CreatedAt.jsx
Outdated
|
|
||
| export const LikeButton = ({ thoughtId, initialHearts }) => { | ||
| // State to track if like action is in progress | ||
| const [isLiking, setIsLiking] = useState(false); |
There was a problem hiding this comment.
What's the purpose of this? 👀
src/components/SubmitThought.jsx
Outdated
Comment on lines
42
to
53
| .then(newThought => { | ||
| // Check if the API returned an error | ||
| if (newThought.error) { | ||
| setError(newThought.error); | ||
| return; | ||
| } | ||
| setMessage(''); // Clears the input | ||
| onSubmit(newThought); // Updates the list | ||
| }) | ||
| .catch(() => { | ||
| setError('Something went wrong. Please try again.'); | ||
| }); |
| return ( | ||
| <form onSubmit={handleSubmit} className="submit-form"> | ||
| <h2>What's making you happy right now?</h2> | ||
| <textarea |
There was a problem hiding this comment.
Don't forget labels! And be mindful when working with textareas, it's good to remove the resize option so that the user don't break the styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://happythoughtsapp-byjenny.netlify.app/