Mikas happy thoughts project #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Hi Mika! For upcoming projects I'd love to see you commit a bit more often. See it as your way to save your progress whenever you've implemented a feature or new functionality.
You've split your components into manageable components and you've done a nice job copying the design too. I put some comments throughout your code to think about for upcoming projects.
Comment on lines
+7
to
+25
| try { | ||
| const res = await fetch(URL, { | ||
| method: "POST", | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| }, | ||
| body: JSON.stringify({ message: message }), | ||
| }); | ||
|
|
||
| if (!res.ok) { | ||
| throw new Error(`HTTP error! status: ${res.status}`); | ||
| } | ||
|
|
||
| const data = await res.json(); | ||
| setThoughts((prevThoughts) => [data, ...prevThoughts]); | ||
| setMessage(""); | ||
| } catch (error) { | ||
| console.error("Error submitting thought:", error); | ||
| } |
Comment on lines
+34
to
+39
| <input | ||
| type="text" | ||
| value={message} | ||
| onChange={(e) => setMessage(e.target.value)} | ||
| required | ||
| /> |
There was a problem hiding this comment.
Don't forget labels when working with form elements! And perhaps this should be a textarea since it's a multiline input?
| return data; | ||
| }; | ||
|
|
||
| export const formatTimeAgo = (timestamp) => { |
There was a problem hiding this comment.
Nice! However, does this really belong in an api.js file? 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mikashappythoughts.netlify.app/