-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Happy thoughts Emelie Kedert #91
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, really good job following the design! It looks exactly like the picture (or maybe even better), kudos!
Good job splitting up your work into different components, however, I think you can work a bit on the naming so that it’s clear what each component does. Maybe it just confuses me that Post is a method of fetch, but also a synonym to Message - so PostLikes could mean ”send like” or ”likes of a message” if that makes sense? And the names AddPost and PostForm are very similar, I wouldn’t know where to look for the POST fetch if that makes sense.
Apart from that I think you managed well with this week’s goals and your code is easy to follow. Really nice with a loading state as well! Keep up the good work Emelie ⭐️
src/index.css
Outdated
height: 70px; | ||
width: 100%; | ||
box-sizing: border-box; | ||
resize: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️
Netlify link
https://happy-thoughts-project-technigo.netlify.app/