Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy Thoughts! #443

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"editor.defaultFormatter": "rvest.vs-code-prettier-eslint",
"editor.formatOnPaste": false, // required
"editor.formatOnType": false, // required
"editor.formatOnSave": true, // optional
"editor.formatOnSaveMode": "file", // required to format on save
"files.autoSave": "onFocusChange", // optional but recommended
"vs-code-prettier-eslint.prettierLast": false, // set as "true" to run 'prettier' last not first
}
12 changes: 7 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
# Happy Thoughts
During this week we're looking at how to react to changes in state or a component mounting using useEffect.
What you will learn

Replace this readme with your own information about your project.
✓ What component lifecycle means.

Start by briefly describing the assignment in a sentence or two. Keep it short and to the point.
✓ How to use the `useEffect` hook in React to perform actions when components mount, unmount, or when state changes.

## The problem
✓ How to call APIs from React and put the data into state.

Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next?
✓ What it's like to work with an API which you both send and receive data from.

## View it live

Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about.
https://amandas-happy-thoughts.netlify.app/
13 changes: 3 additions & 10 deletions code/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"extends": [
"airbnb"
],
"extends": ["airbnb"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just "tidying up" or does it help with the code? Honest question, anything that helps is good to know! :-D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont even remember doing this 😅 I think it might be the result of some eslint/prettier config?🤔

"globals": {
"document": true,
"window": true,
Expand All @@ -22,9 +20,7 @@
"modules": true
}
},
"plugins": [
"react-hooks"
],
"plugins": ["react-hooks"],
"rules": {
"react/function-component-definition": [
2,
Expand All @@ -42,10 +38,7 @@
"allowSingleLine": true
}
],
"comma-dangle": [
"error",
"never"
],
"comma-dangle": ["error", "never"],
"consistent-return": "off",
"curly": "error",
"eol-last": "off",
Expand Down
Loading