-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Happy Thoughts by Emma Engvall #445
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hej Emma!!
I'm gonna do this is english bc it's easier with all the complicated tech words and we both know...trying to translate them into swedish does NOT sound sexy at all :P
setNewThought(event.target.value) | ||
} | ||
|
||
//Posting a new thought to the API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good comment
const characterWarning = () => { | ||
if (newThought.length > 140 ) { | ||
return ( | ||
<p className="character-warning">You are trying to send too much love.</p>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha too much love is apparently a thing-in this app, atleast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I accidentally submitted my review too early, nevermind the mess.
I loved seeing how closely you were able to follow the design and how incredibly functional your app is. It's doing everything it needs to do. One thing you could improve upon maybe is the responsiveness in mobile. At 320px, the thought form is being cropped quite drastically!
Your code is so clean, easy to read and nice to look at. Keep up the amazing work and I'm sure you will be building even more breathtakingly beautiful apps after the BC <3
No description provided.