Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy Peasy Recipes (by Anna, Gabriella and Gitte) #49

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

gittebe
Copy link

@gittebe gittebe commented Sep 22, 2024

Netlify link

https://library-recipes.netlify.app

Collaborators

[gittebe, Anna2024WebDev, gabster94]

gittebe and others added 30 commits September 17, 2024 12:42
Co-authored-by: Anna Hansen <[email protected]>
Co-authored-by: Fanny Henriques <[email protected]>
Co-authored-by: Fanny Henriques <[email protected]>
Co-authored-by: Gabriella Iofe <[email protected]>
Co-authored-by: Gabriella Iofe <[email protected]>
Co-authored-by: Fanny Henriques <[email protected]>
@gittebe gittebe changed the title Easy Peasy Recipes Easy Peasy Recipes (by Anna, Gabriella and Gitte) Sep 22, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the project!

You have worked really well with functions and conditionals. And from what I can see you have worked well as a team too. Good use of comments in your code files.

One thing, think about why you are sometimes using named functions, and adding them to the event listeners and sometimes you are going with anonymous functions within the event listeners. Both ways are valid and sometimes it can feel verbous to create named functions for everything. But I would suggest, now in the beginning you should stick to one way. Or at least have a discussion about why/why not. This can be somethin you can add in your reflections of the project if you want to. Things like that can be interesting topics for a demo or a talk with a recruiter/ tech interviewer.

Minor thing, <form> doesn't have a valid attribute called for. for can be used on <label> elements,

You've met all requirements, keep up the good work


This project was the first team project as part of the Technigo bootcamp. Working together on the same repository has been a new important experience for us.
We decided on the project together and build a first HTML and CSS together. We worked on the Javascript codes first idividually and explained and discussed them later on.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants