-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easy Peasy Recipes (by Anna, Gabriella and Gitte) #49
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Anna Hansen <[email protected]> Co-authored-by: Fanny Henriques <[email protected]>
Co-authored-by: Fanny Henriques <[email protected]> Co-authored-by: Gabriella Iofe <[email protected]>
Co-authored-by: Gabriella Iofe <[email protected]> Co-authored-by: Fanny Henriques <[email protected]>
Co-authored-by: Gabriella Iofe <[email protected]>
…vidual information for each card
added netlify link
added link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the project!
You have worked really well with functions and conditionals. And from what I can see you have worked well as a team too. Good use of comments in your code files.
One thing, think about why you are sometimes using named functions, and adding them to the event listeners and sometimes you are going with anonymous functions within the event listeners. Both ways are valid and sometimes it can feel verbous to create named functions for everything. But I would suggest, now in the beginning you should stick to one way. Or at least have a discussion about why/why not. This can be somethin you can add in your reflections of the project if you want to. Things like that can be interesting topics for a demo or a talk with a recruiter/ tech interviewer.
Minor thing, <form>
doesn't have a valid attribute called for. for can be used on <label>
elements,
You've met all requirements, keep up the good work
|
||
This project was the first team project as part of the Technigo bootcamp. Working together on the same repository has been a new important experience for us. | ||
We decided on the project together and build a first HTML and CSS together. We worked on the Javascript codes first idividually and explained and discussed them later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Netlify link
https://library-recipes.netlify.app
Collaborators
[gittebe, Anna2024WebDev, gabster94]