Jonas Music release app #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AristName, Header, AlbumCover.
…where everything will be displayed. I also added simple styling so that the cards are shown 4 in a row on desktop, with a black background and white text.
…s (heart, play, and dots) beneath the image. These icons are imported from SVG files and represent different functions (e.g., like, play, and menu).
…ts) on hover. I used z-index to layer the icons above the overlay and applied a CSS filter to turn them white. Added hover effects to increase icon visibility and responsiveness.
…etween them. I also styled the links to remove the underline by default and added an underline when hovering over the artist names.
JennieDalgren
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Great job with the project, you are meeting all requirements! 🎊
You are doing a great job of passing data down as props. It keeps the components simple and focused on their specific tasks. The use of prop-driven components is a key strength of React.
The hierarchy of components (from App.jsx down to ArtistName.jsx) is well-structured. Each component has a clear responsibility, making the app more maintainable. This will be even more important when we build bigger projects.
Stay golden ⭐
Comment on lines
+16
to
+19
| Positioning icons correctly: Initially, the icons were hidden behind the overlay. I resolved this by adjusting the z-index so that the icons appear above the overlay on hover. | ||
| Handling commas between artist names: I needed to dynamically add commas between artist names. I solved this by using conditional logic in the ArtistName component. | ||
| Styling issues: I encountered problems with unwanted spaces and default underlines on links. I fixed these by adjusting margins and using text-decoration: none for the default state and underline for the hover state. | ||
| These changes allowed the app to function as expected and match the project requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jonas-music-releases.netlify.app/