Music Release Project #105
Conversation
There was a problem hiding this comment.
Good job, you meet all requirements!
Good structure of your project, it includes several components, such as Album.jsx, CoverImage.jsx, AlbumName.jsx, and ArtistName.jsx.
Interesting that you've tried out prop-types. How come? And how did you feel about it? We will learn more about typing when we learn about TypeScript. Feel free to use prop types if you want to.
Really nice implementation of the sidebar aswell and the different scrolling of the sections.
Overall Feedback:
You've done an excellent job at structuring your project into components and passing props efficiently. Each component is focused on a specific task, and the use of PropTypes is a strong practice for type safety.
This is a very well-organized and solid project! Keep up the great work, you're really mastering React fundamentals!
Stay golden ⭐
src/components/Album.jsx
Outdated
| <CoverImage | ||
| coverImg={album.images.length > 0 ? album.images[0].url : 'fallback-image-url.jpg'} | ||
| albumUrl={album.external_urls.spotify} |
| import PropTypes from 'prop-types' | ||
|
|
||
| // Album Name | ||
| export const AlbumName = ({ name, albumUrl }) => { |
There was a problem hiding this comment.
Good practise to only pass along the data that this component needs to know about.
https://gittes-music-release.netlify.app/