xings music libary #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JennieDalgren
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Great job with this project!
You have used components in a really good way, really practising passing props.
Good job with the strcutre of your files, and in the css as well.
When the projects grow, one idea is to split up the css to specific components as well. But more on that later!
Keep up the good work.
Comment on lines
+29
to
+49
| Album.propTypes = { | ||
| album: PropTypes.shape({ | ||
| name: PropTypes.string.isRequired, | ||
| images: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| url: PropTypes.string.isRequired, | ||
| }) | ||
| ).isRequired, | ||
| external_urls: PropTypes.shape({ | ||
| spotify: PropTypes.string.isRequired, | ||
| }).isRequired, | ||
| artists: PropTypes.arrayOf( | ||
| PropTypes.shape({ | ||
| name: PropTypes.string.isRequired, | ||
| external_urls: PropTypes.shape({ | ||
| spotify: PropTypes.string.isRequired, | ||
| }).isRequired, | ||
| }) | ||
| ).isRequired, | ||
| }).isRequired, | ||
| }; |
There was a problem hiding this comment.
Do you understand this part? We have not gone through it. It's important that you understand the code, even though you've gotten help from your collaborator. :)
Comment on lines
+14
to
+16
| AlbumList.propTypes = { | ||
| albums: PropTypes.arrayOf(PropTypes.object).isRequired, | ||
| }; |
There was a problem hiding this comment.
Again, prop types is nice to understand. But we haven't really gone thru it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://xingsmusiclibary.netlify.app/
Collaborators
My friend ChatGPT