Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio-Emelie-Nyberg #388

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

EmelieNyberg
Copy link

Netlify link

https://emelie-nyberg-portfolio.netlify.app/

Not 100% pleased with the result. If I had more time I would make som more reusable components and better responsivness on mobile devices.

@JennieDalgren JennieDalgren self-assigned this Nov 7, 2024
Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project!
You've met all requirements. However the a11y score on Lighthouse is a bit low, but I will doublecheck this with the scoring in Figma and that design, because it's on the designer, not on you!

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants