Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fannys Portfolio #401

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Fannys Portfolio #401

wants to merge 29 commits into from

Conversation

Fannyhenriques
Copy link

@Fannyhenriques
started with project portfolio
512ed61
@Fannyhenriques
added components and styling
e5eb611
@Fannyhenriques
added tagscomponent in tags, projects and articles, and added styling
79918ae
@Fannyhenriques
added props in gridsection.jsx
7396213
@Fannyhenriques
fixed grid-layout for articles and projects
a5f0d36
@Fannyhenriques
added styling for buttons
7c7d959
@Fannyhenriques
refined styling for buttons
c39676a
@Fannyhenriques
updated styling for tags inside the skills and overall styling for sk…
1b2c37f 
…ills
@Fannyhenriques
added iconbutton.jsx with styling for the buttons in the letstalk-sec…
84f91db 
…tion
@Fannyhenriques
added styling in gallary for the images
32e1c0d
@Fannyhenriques
added links to the buttons in project and articlesections
c0d1f18
@Fannyhenriques
added styling for responsiveness in articles and projects and grid
8f81618
@Fannyhenriques
fiexed responsive design for header
d1349b5
@Fannyhenriques
finnished overall responsive styling
09c7c28
@Fannyhenriques
added padding
9dbd833
@Fannyhenriques
changed name for icon and updated pathway
ca0dda4
@Fannyhenriques
testcommit to se if icon works
e59afe7
@Fannyhenriques
removed icon stackoverflow because of error in netlify
85c2848
@Fannyhenriques
added icon stackoverflow again
97894c8
@Fannyhenriques
added important in default styling in articles section because it is …
163494e 
…not working on netlify
@Fannyhenriques
push-test for deploying to netlify again
8436666
@Fannyhenriques
added media queries for the default styling for the netlify-site
10d2466
@Fannyhenriques
fixed indentations
59e999c
@Fannyhenriques
changed white and black to primary and secondary color
6d16f5c
@Fannyhenriques
added readme
925f84a
@Fannyhenriques
removed the second readme that is not being used
2fcae15
@Fannyhenriques
added links to buttons
ae77565
@Fannyhenriques
spacing
0ab13c1
HIPPIEKICK
HIPPIEKICK requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I'd just like to ask you to do another take on the buttons:

  • hover effect
  • correct font
  • remove border
  • change them to <a> tags instead of using button with onclick

Apart from that, it looks super ⭐

@Fannyhenriques
added hovereffect on buttons, changed the buttoncomponent to use an a…
5763aef 
…nchor <a>tag, updated the parentcomponents with href, added the correct fontweight to the buttons
@Fannyhenriques
Copy link
Author

Thank you so much for the feedback, @HIPPIEKICK! ☺️ I’ve updated the buttons as suggested. However, I’m a bit unsure about what you meant by removing the border. The buttons with borders (the "View More" buttons) are styled that way to match the Figma design. Removing the borders would make the site differ from the original design. Could you clarify if you meant something else? 😊

@HIPPIEKICK
Copy link
Contributor

Thank you so much for the feedback, @HIPPIEKICK! ☺️ I’ve updated the buttons as suggested. However, I’m a bit unsure about what you meant by removing the border. The buttons with borders (the "View More" buttons) are styled that way to match the Figma design. Removing the borders would make the site differ from the original design. Could you clarify if you meant something else? 😊

I think you solved it by changing to a-tags! The button-tags has a default border, but a-tags do not 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HIPPIEKICK HIPPIEKICK HIPPIEKICK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fannyhenriques @HIPPIEKICK