To-Do-Project #35
Open
To-Do-Project #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Hi Gitte! Your stores are set up nicely and I like that you've used the persist middleware. Please think about cleaning up your code and indenting properly going forward. Remove unnecessary fragments.
Your UI is a little bit off - have a look at your overall layout in big screens. Also, I argue that a checked box is usually filled with color and an unchecked box is not 👀
I'm approving, but please think about this going forward and have a look at this when you have time.
src/App.jsx
Outdated
Comment on lines
5
to
8
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| width: 100%; |
src/App.jsx
Outdated
Comment on lines
12
to
16
| <> | ||
| <AppStyle> | ||
| <Home /> | ||
| </AppStyle> | ||
| </> |
There was a problem hiding this comment.
No need for a fragment when you already have a div wrapping
JennieDalgren
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gittes-to-do-list-application.netlify.app/