To-Do App #36
Open
To-Do App #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Nov 26, 2024
| @@ -0,0 +1,46 @@ | |||
| .app-container { | |||
| display: flex; | |||
There was a problem hiding this comment.
Seems like all of your code has too much indentation? Set your VSC to be 2 spaces please
Comment on lines
+7
to
+8
| const moveTaskUp = useTaskStore((state) => state.moveTaskUp); | ||
| const moveTaskDown = useTaskStore((state) => state.moveTaskDown); |
Comment on lines
+85
to
+93
| function loadTasksFromLocalStorage() { | ||
| const savedTasks = localStorage.getItem(LOCAL_STORAGE_KEY); | ||
| return savedTasks ? JSON.parse(savedTasks) : null; | ||
| } | ||
|
|
||
| // Save tasks to localStorage | ||
| function saveTasksToLocalStorage(tasks) { | ||
| localStorage.setItem(LOCAL_STORAGE_KEY, JSON.stringify(tasks)); | ||
| } |
There was a problem hiding this comment.
Why not arrow functions here? 👀
|
Great job with your typescript implementation all requirements met ⭐️, I've checked your code in your repo but cannot see that here in the PR. Doesnt matter, but thats why I'm adding this comment here. I can't comment on your own repo, only the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://helenes-todolist.netlify.app/