Jonas To-Do-List #38
Open
Jonas To-Do-List #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Nice to see you're continuing with Styled components 🥳 Your code overall looks good and your Zustand store is well-structured.
Changes Requested
Please pay attention to following the clean code guidelines. All small things add up and it will make your project look so much better if you cleaned it up. Let me know if you have any questions
|
@HIPPIEKICK Thank you for the feedback! :) I’ve addressed all the points mentioned and ensured the code follows the clean code guidelines. Please let me know if there’s anything else I might have missed or if further adjustments are needed. |
HIPPIEKICK
approved these changes
Dec 4, 2024
| }; | ||
| import MyToDoListPage from "./Page/MyToDoListPage"; | ||
|
|
||
| function App() { |
There was a problem hiding this comment.
Why not an arrow function here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jonas-to-do-list.netlify.app/