Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-15-to-dos-zustand-vite #39

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

erikamolsson
Copy link

@erikamolsson
Copy link
Author

Forgot completely to commit in this project, thats why its so few...

Not completely done, need the "count of the tasks" still.

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on good way with this project Erika! As you wrote, you still have the count left, but you've met the other requirements. Your Zustand store is clean and really easy to follow - kudos!

Also nice to see that you've continued with styled components. I'd like to add a comment on the UI of your app for you to think about if you have extra time: for me, it took a couple of seconds to understand what I was looking at and where to find out how to add a task. After clicking the button to add a task in the far corner, I couldn't start typing immediately, but had to click the input (would be nice to focus it). After writing a task I, again, had to click (would be nice with just an Enter press here), before going to the far corner again to write a new task. Just something to think about.

Changes Requested

  • Include a count

src/App.jsx Outdated
@@ -1,3 +1,28 @@
import React from "react";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to import React

<Overlay>
<PopupContainer>
<h2>Add a new todo</h2>
<Input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't leave out labels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants