To do app - Jenny A #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Nov 27, 2024
| @@ -0,0 +1,36 @@ | |||
| // components/EmptyState.jsx | |||
| import styled from 'styled-components' | |||
| import Lottie from 'lottie-react' | |||
There was a problem hiding this comment.
Nice with some lottie animations 🥳
|
|
||
| return ( | ||
| <InputWrapper onSubmit={handleSubmit}> | ||
| <Input |
Comment on lines
+2
to
+8
| import styled from 'styled-components' | ||
| import { useState } from 'react' | ||
| import { useTodoStore } from '../stores/TodoStore' | ||
| import { TodoInput } from '../components/TodoInput' | ||
| import { TodoList } from '../components/TodoList' | ||
| import Lottie from 'lottie-react' | ||
| import todoAnimation from '../assets/todo-animation.json' |
There was a problem hiding this comment.
Minor thing, but your code looks so good, so I don't have much to comment on 😉
You can order your imports like this:
import { useState } from 'react'
import Lottie from 'lottie-react'
import styled from 'styled-components'
import todoAnimation from '../assets/todo-animation.json'
import { useTodoStore } from '../stores/TodoStore'
import { TodoInput } from '../components/TodoInput'
import { TodoList } from '../components/TodoList'
with external libraries first (with react hooks first for clarity, but the others in albhabetical order).
Secondly assets, then stores, followed by components (in alphabetical order)
There was a problem hiding this comment.
Well structured with clear names on your actions and easy-to-follow code 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://everyday-to-do.netlify.app/