Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mikas To-dos #44

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Mikas To-dos #44

wants to merge 43 commits into from

Conversation

mikaeber
Copy link

Netlify link

mikas-tasklist.netlify.com

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the project this week Mika! I really appreciate your modular approach and I think you've done elaborate work with the UI as well. Some small comments on the UI and responsiveness:

  • Have a look at 320px width, it gets a little cramped and the tasks become scrollable even though there's only one line of text
  • What's up with the three dots (I interpret it as settings)
  • Default deadline is today, but it doesn't show up in "Tasks due this week". But when I write tomorrow as a deadline it says "Due today"

I see you've installed a lot of drag and drop libs - super nice idea! But please remove the code you're not using or be clear with what the next step is.

You've done a lot of cool things here and really made this project your own, so kudos for that! I really like the graph representation 🥳

Now to the requirements... You're Zustand stores are well-structured and your code overall is modular and clean. However, one requirement doesn't seem to be met - 95% score in lighthouse. Have a look and let me know!

Changes Requested

  • Accessibility (Lighthouse)

Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with implementing typescript into this project.
Some of the points Matilda pointed out last week is still to be fixed in order to get approved. It's not fully responsive and the a11y score should be higher.

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants