-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tess Aquilon - Project Todos #454
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean and nice site! I love the colors and the theme, super cute!!
The complete and delete buttons are intuitive and easy to understand. The code is clean and easy to read, although I think some comments here or there might be helpful for the future or for someone who didn't just do the exact same project 😅
The one thing I can see might improve it is that there seems to be some pictures left from earlier designs in the repo, maybe delete them?
Well done!
const onFormSubmit = (event) => { | ||
event.preventDefault(); | ||
const newTodo = { | ||
id: Date.now().toString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice way of doing the unique id
code/src/index.css
Outdated
box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.2); | ||
} | ||
|
||
ul { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of grid areas here
code/src/components/AddTodo.js
Outdated
required /> | ||
</label> | ||
<div className="lazy-cat-main"> | ||
<Player |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the animation!
code/src/index.css
Outdated
text-align: start; | ||
} | ||
|
||
.lazy-cat-header { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting way of solving the moving of the animation between different screen sizes
https://gregarious-griffin-0ee914.netlify.app/