Emelie Nyberg Kedert

[EmelieNyberg]

Netlify link

https://weatherapp-ek.netlify.app/

[HIPPIEKICK]

HTML/CSS

• Your HTML structure looks solid, but I'd consider using more semantic HTML tags instead of going for this many divs.
• I think you managed well to follow the given design! A tiny thing would be to have a look at how the temperatures are displayed on small mobile (they don't fit on one line)

JavaScript

• Good job structuring and naming your DOM selectors and global variables 👍
• You haven’t implemented any error handling in case the API call fails. I recommend adding a .catch() to handle any issues, such as network errors or invalid API responses.

fetch(URL_WEATHER)
  .then(response => {
    if (!response.ok) {
      throw new Error('Weather data not found');
    }
    return response.json();
  })
  .then(data => {
    // Handle data
  })
  .catch(error => {
    console.error('Error fetching weather data:', error);
    viewCurrentWeatherText.textContent = 'Unable to retrieve weather data';
  });

• You've already mentioned this in your Readme (great reflections by the way ✨ ), but I'm putting it here anyway: You could really benefit from creating separate functions to handle different tasks, such as updating the DOM elements, to avoid crowding the getTodaysWeather() function. This would make your code more modular and easier to maintain.

Clean Code
Your code is clean overall ⭐ When making multiple fetch requests (e.g., for the current weather and the forecast), you could refactor the fetch logic into a reusable function to reduce code repetition. Not a requirement, just an idea 😄

No changes requested, keep up the good work! 🌞

[HIPPIEKICK]

👍