Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ADC calculation #23

Merged
merged 8 commits into from
Dec 7, 2024
Merged

Refactor ADC calculation #23

merged 8 commits into from
Dec 7, 2024

Conversation

giladmaya
Copy link
Collaborator

Refactored ADC pre-processing command -

  1. Fixed CLI input handling
  2. Added missing click requirement
  3. Wrap dicom reader/writer handling
  4. Added warning messages

General

  1. Added help to CLI parameters
  2. Use click options to make CLI commands easier to use

Copy link

github-actions bot commented Dec 7, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
pd_dwi
   __init__.py20100% 
   dataset.py463230%12, 15–18, 20–22, 24, 26–27, 29, 31–32, 34–37, 39–43, 45, 47–49, 56, 59, 62, 66, 69
   model.py803753%56, 58–60, 62–63, 66, 68–70, 72–73, 77–78, 80–82, 84–85, 87–88, 90, 92–94, 100–111
   training_utils.py53492%27–28, 60, 84
pd_dwi/config
   __init__.py00100% 
   config.py71198%100
   utils.py11190%15
pd_dwi/dcm_utils
   __init__.py00100% 
   reader.py553929%8–11, 15–16, 18–23, 25–27, 29, 32–34, 36–40, 42–43, 45–46, 50–52, 54, 59–62, 66, 70, 74
   tags.py28485%7–8, 14, 17
   writer.py412539%17–18, 20–21, 24, 27, 30–31, 34, 36–37, 39–40, 43–44, 46, 48, 55–58, 61, 64, 67–68
pd_dwi/feature_selection
   __init__.py00100% 
   select_k_best.py60100% 
pd_dwi/models
   __init__.py12466%14–16, 18
pd_dwi/preprocessing
   __init__.py00100% 
   adc.py682858%21, 24, 26, 28–34, 36–37, 39, 42, 44, 46–51, 83–84, 86–87, 89, 91, 93
   column_transformer.py10460%14–15, 18, 20
pd_dwi/preprocessing/transformers
   __init__.py00100% 
   hormone_receptor_encoder.py19952%16–17, 19, 22–24, 26, 29, 32
   radiomics_encoder.py692859%40, 43, 55–56, 58, 61, 63–64, 66, 68, 71, 74, 77–82, 84–85, 87, 90, 93–98
   sbr_grade_encoder.py21957%18–19, 22, 24, 27–28, 30, 33, 36
pd_dwi/scripts
   __init__.py00100% 
   adc_preprocess_command.py271737%10–12, 22–25, 27, 29–30, 32–33, 35–36, 38–40
   cli.py190100% 
   list_command.py70100% 
   predict_command.py14657%16, 18–19, 21–22, 24
   score_command.py8275%11–12
   train_command.py10370%12–14
TOTAL67725362% 

@giladmaya giladmaya merged commit 4df0222 into main Dec 7, 2024
2 checks passed
@giladmaya giladmaya deleted the fix/adc_calc branch December 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant