#17 add pathdep remover #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
approved these changes
Mar 13, 2024
| def handle(self) -> int: | ||
| path_dependency_remover = PathDependencyRemover() | ||
| path_dependency_remover.update_dependency_group( | ||
| self.io, self.poetry.pyproject, self.poetry.package.dependency_group("main") |
There was a problem hiding this comment.
S (Substantive): this is probably fine for this version, but we likely would need to be able to handle when export is called with other groups with the --with <groups> option too?
There was a problem hiding this comment.
Curious how the build/publish rewrite was working with the monorepo group, given it uses a very similar implementation.
ewilkins-csi
approved these changes
Mar 13, 2024
aaron-gary
reviewed
Mar 13, 2024
src/poetry_monorepo_dependency_plugin/path_dependency_remover.py
Outdated
Show resolved
Hide resolved
aaron-gary
reviewed
Mar 13, 2024
aaron-gary
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry path-based dependencies defined under the monorepo dependency group will fail to be resolved upon export on any machine that is not the one on which the original export was performed.
In order to prevent such dependency resolving failures, it is needed to extend poetry's export command such that any path-based dependencies are not included in the resultant requirements.txt.