Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Layout & Storyboard Support #8

Merged
merged 4 commits into from
Feb 13, 2014
Merged

Horizontal Layout & Storyboard Support #8

merged 4 commits into from
Feb 13, 2014

Conversation

Sam-Spencer
Copy link
Contributor

Added support for UICollectionViews which scroll horizontally instead of vertically. Now TLSpringFlowLayout will animate and properly layout both vertical and horizontal collection views.

Improved init methods to support initialization from either a Storyboard (initWithCoder:) or directly from code (init). Both methods call a common setup method.

Attempted to fix issue #5 by adding the prepareForCollectionViewUpdates: method.

Added a storyboard to the demo project.

Updated details in the Readme.md file.

Sam Spencer added 2 commits February 8, 2014 17:14
Added support for horizontal UICollectionViews, now allows for setup from storyboard or via code, and added a storyboard example
Added information to the readme
@@ -8,6 +8,14 @@

#import <UIKit/UIKit.h>

#define kScrollResistanceFactorDefault 900.0f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use an extern variable here instead of a #define?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashfurrow Well, why would extern be used - can't the value be changed if it's an extern (I'm not familiar with using extern)? This is the default value and it should be unchanging. Maybe a static variable would be better? Maybe it shouldn't be public?

@ashfurrow
Copy link
Contributor

Looks great, thanks for doing this! Just a few questions I have above.

Sam Spencer added 2 commits February 11, 2014 21:23
Added Storyboard files (forgot to include in last commit), updated TLSpringFlowLayout with more documentation and an iOS 7.0 check, removed unneeded demo app code.
Updated sample project - added icons to tab bar and app, changed tint color to match Teehan+Lax colors, fixed collection view issue (noted in Pull Request comments).
@Sam-Spencer
Copy link
Contributor Author

@ashfurrow I fixed the issue with the loading of the collection view's cells. I also changed the tint color of the app to match Teehan+Lax's colors (or close to it). See commit 161a427 and commit db6e96b.

ashfurrow added a commit that referenced this pull request Feb 13, 2014
Horizontal Layout & Storyboard Support
@ashfurrow ashfurrow merged commit 8ca3a6e into TeehanLax:master Feb 13, 2014
@ashfurrow
Copy link
Contributor

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants