-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal Layout & Storyboard Support #8
Conversation
Added support for horizontal UICollectionViews, now allows for setup from storyboard or via code, and added a storyboard example
Added information to the readme
@@ -8,6 +8,14 @@ | |||
|
|||
#import <UIKit/UIKit.h> | |||
|
|||
#define kScrollResistanceFactorDefault 900.0f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use an extern
variable here instead of a #define
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashfurrow Well, why would extern
be used - can't the value be changed if it's an extern
(I'm not familiar with using extern
)? This is the default value and it should be unchanging. Maybe a static
variable would be better? Maybe it shouldn't be public?
Looks great, thanks for doing this! Just a few questions I have above. |
Added Storyboard files (forgot to include in last commit), updated TLSpringFlowLayout with more documentation and an iOS 7.0 check, removed unneeded demo app code.
Updated sample project - added icons to tab bar and app, changed tint color to match Teehan+Lax colors, fixed collection view issue (noted in Pull Request comments).
@ashfurrow I fixed the issue with the loading of the collection view's cells. I also changed the tint color of the app to match Teehan+Lax's colors (or close to it). See commit 161a427 and commit db6e96b. |
Horizontal Layout & Storyboard Support
🍻 |
Added support for UICollectionViews which scroll horizontally instead of vertically. Now
TLSpringFlowLayout
will animate and properly layout both vertical and horizontal collection views.Improved init methods to support initialization from either a Storyboard (
initWithCoder:
) or directly from code (init
). Both methods call a commonsetup
method.Attempted to fix issue #5 by adding the
prepareForCollectionViewUpdates:
method.Added a storyboard to the demo project.
Updated details in the Readme.md file.