Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipv4_gateway_format dict #31

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Jun 14, 2024

It had the same translation as for gatewayip resulting in not being able to select that attribute in the list of "Configure this list".

@xtophe38
Copy link
Member

@Hipska I'd actualy translate a bit differently these 3 labels. In the case of the IPv4Subnet:

  • gatewayip: Gateway IP
  • ipconfig_ipv4_gateway_ip_format: Default gateway IP format (in the IPv4 subnet page)
  • ipconfig_ipv4_gateway_ip_format: IPv4 Gateway IP Format (in the Global IP Settings page)
  • ipv4_gateway_ip_format: Gateway IP format

@Hipska
Copy link
Contributor Author

Hipska commented Jul 8, 2024

Done, I also updated the same for IPv6 subnets.

@xtophe38 xtophe38 merged commit d164214 into TeemIp:master Aug 1, 2024
@Hipska Hipska deleted the fix/ipv4_gateway_format branch August 5, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants