Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json-ld rather than custom calculation of shape #20

Merged
merged 74 commits into from
Jun 15, 2024
Merged

Use json-ld rather than custom calculation of shape #20

merged 74 commits into from
Jun 15, 2024

Conversation

Teester
Copy link
Owner

@Teester Teester commented Nov 29, 2021 •
edited
Loading

This pull request converts the api to use a json-ld version of the shape to compare against rather than the custom computed version that is currently used. Solves #18

@Teester Teester linked an issue Nov 29, 2021 that may be closed by this pull request
Use PyShExC to generate shapes in JSON-LD #18
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

97.1% 97.1% Coverage
2.5% 2.5% Duplication

@Teester
Remove unused variable
66ad771
@Teester
Remove unused variable
b1cd45e
@Teester
Use assertIn where appropriate
1ba5620
@Teester
Updating where the html is inserted into the wikidata page
e9cadea
@Teester
Add a test to check that an incorrect statement is returned as such
81ccd26
@Teester
Fix a grammatical error
50f5783
@Teester
Add a test to ensure "too many statements" is returned correctly
9ff3b5c
@Teester
Simplify CompareProperties._process_cardinalities
ee56e2f
@Teester
Change CompareProperties._process_triple_constraint to only process a…
d92663a 
…gainst elements with that property
@Teester
Change CompareStatements._process_shape to take EXTRA into account
7791a63
@Teester
Change CompareStatements._process_triple_constraint to only process a…
01c8d2d 
…gainst elements with that property
@Teester
Assume cardinalities are 1 when there's nothing present in the JSONLD
31f076c
@Teester
Set node constraints as incorrect if they do not match the shape's re…
9b1d2de 
…quirements
@Teester
Fixing some typos and PEP8 errors
f73fcd4
@Teester
Fixing Sonarlint issues
6f28616
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Teester Teester merged commit 5120ca8 into master Jun 15, 2024
3 of 5 checks passed
@Teester Teester deleted the Rearrange branch June 15, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use PyShExC to generate shapes in JSON-LD
1 participant
@Teester