Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embeddings from obsm after query mapping #8

Open
emdann opened this issue Nov 23, 2022 · 1 comment
Open

Remove embeddings from obsm after query mapping #8

emdann opened this issue Nov 23, 2022 · 1 comment

Comments

@emdann
Copy link
Member

emdann commented Nov 23, 2022

In every new MultiViewAtlas object made by tl.add_query, reset the embeddings in obsm, cos these need recomputing.
Better even: put in a param keep_obsm set to False by default.
@emdann
Copy link
Member Author

emdann commented Nov 23, 2022 •
edited
Loading

Nope: you don't want to remove if the X_scVI dims are in atlas... but you should set the query cells to 0 or np.nan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emdann