Feat/cgw kafka key in replies #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Mazur <[email protected]>
Remove unused shard id argument from cli parser in <generic> (assign to <any>) infra group create request. Signed-off-by: Oleksandr Mazur <[email protected]>
The provided kafka key in (some of the) replies can be used by NB services to talk <directly> to _this_ local shard that replied, effectively using kafka partitioning to not rely on the relaying mechanism. The keys list is calculated upon each kafka partition rebalancing, if the partition number changes. Signed-off-by: Oleksandr Mazur <[email protected]>
The predefined mac list in the txt file is used internally by the client simulator. It was missed in previous commits. Future clientsim rework should eliminate use of <predefined> mac lists, but it's used now. Signed-off-by: Oleksandr Mazur <[email protected]>
SviatoslavBoichuk
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.