Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOS-10712: Added left image #409

Merged
merged 3 commits into from
Nov 12, 2024
Merged

IOS-10712: Added left image #409

merged 3 commits into from
Nov 12, 2024

Conversation

WanaldinoTelefonica
Copy link
Contributor

@WanaldinoTelefonica WanaldinoTelefonica commented Nov 8, 2024 •
edited
Loading

🎟️ Jira ticket

IOS-10712

🥅 What's the goal?

  • Add the left image to the Button component

🚧 How do we do it?

  • Follow the same rules as the right image

🧪 How can I verify this?

🏑 AppCenter build

https://install.appcenter.ms/orgs/Tuenti-Organization/apps/Mistica-SwiftUI-iOS/distribution_groups/public/releases/72
image

@WanaldinoTelefonica WanaldinoTelefonica requested review from a team, aweell, DavidMarinCalleja and alejandroruizponce and removed request for a team November 8, 2024 09:26
@WanaldinoTelefonica WanaldinoTelefonica marked this pull request as ready for review November 8, 2024 09:35
@DavidMarinCalleja
Copy link
Contributor

don't we have new screensot testing updated for this component?

@aweell
Copy link

aweell commented Nov 8, 2024 •
edited
Loading

I downloaded version 33.2.0(1) from Nov 08, 2024 at 10:29 but i can't see what's displayed in this screenshot

I'm downloading the wrong version?

image

@aweell aweell requested review from yceballost and removed request for aweell November 8, 2024 19:07
@WanaldinoTelefonica WanaldinoTelefonica requested review from cbarcom and removed request for DavidMarinCalleja November 11, 2024 10:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Nov 11, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/11777077621

@WanaldinoTelefonica
Copy link
Contributor Author

don't we have new screensot testing updated for this component?

Already added new tests for the feature

@WanaldinoTelefonica
Copy link
Contributor Author

WanaldinoTelefonica commented Nov 11, 2024 •
edited
Loading

I downloaded version 33.2.0(1) from Nov 08, 2024 at 10:29 but i can't see what's displayed in this screenshot

I'm downloading the wrong version?

image

I've regenerated the build in case it was wrong and updated the link and QR

@WanaldinoTelefonica WanaldinoTelefonica self-assigned this Nov 11, 2024
yceballost
yceballost approved these changes Nov 12, 2024
View reviewed changes
...s/MisticaTests/UI/__Snapshots__/ButtonTests/testLeftImageAndChevron.with-blau-dark-style.png
Copy link
Contributor

@yceballost yceballost Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buttonPrimary and secondary dont allow chevron on the right side. This case do not exists in specs

this example in catalog should not be there

@WanaldinoTelefonica WanaldinoTelefonica merged commit f0957d2 into main Nov 12, 2024
2 checks passed
@WanaldinoTelefonica WanaldinoTelefonica deleted the IOS-10712-Button-left-image branch November 12, 2024 10:28
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 33.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandroruizponce alejandroruizponce alejandroruizponce approved these changes

@cbarcom cbarcom cbarcom approved these changes

@yceballost yceballost yceballost approved these changes

Assignees

@WanaldinoTelefonica WanaldinoTelefonica

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@WanaldinoTelefonica @DavidMarinCalleja @aweell @tuentisre @yceballost @cbarcom @alejandroruizponce