Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101-Remove-TLMemorizeNodePositionAction-since-it-is-not-in-Telescope-spirit #148

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
+8 −45
Open

101-Remove-TLMemorizeNodePositionAction-since-it-is-not-in-Telescope-spirit #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
476c7f5
Remove TLMemorizeNodePositionAction.
jecisc Jul 8, 2019
89b84e9
Start migration guide.
jecisc Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions resources/MigrationV2to3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Migration Guide - Telescope v2 to v3

This guide will cover the different breaking changes introduced in Telescope v3.0.0

## Removal of TLMemorizeNodePositionAction

`TLMemorizeNodePositionAction` was an action introduced to save the positions of elements in visualization. It was removed in the v3 without replacement. This decision after trying to use it in production. The interactive property of Telescope make this feature unusable because layouts always update and will overlap with the fixed entities.

7 changes: 0 additions & 7 deletions src/Telescope-Core/TLDrawable.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,6 @@ TLDrawable >> defaultStyle [
^ #drawable
]

{ #category : #style }
TLDrawable >> effectiveStyleSheet [
^ self
buildCompositeStyleSheetFrom:
(self parent ifNil: [ self styleSheetClass new ] ifNotNil: [ self parent effectiveStyleSheet ])
]

{ #category : #'private-connector' }
TLDrawable >> generate [
| result |
Expand Down
3 changes: 0 additions & 3 deletions src/Telescope-Core/TLDrawableCollection.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ Class {
#superclass : #OrderedCollection,
#traits : 'TTLConnectable - {#connectTo:. #connectIfNotTo:. #connectTo:entity:} + TTLDrawableCollection',
#classTraits : 'TTLConnectable classTrait + TTLDrawableCollection classTrait',
#instVars : [
'sortingStrategy'
],
#category : #'Telescope-Core-Model'
}

Expand Down
19 changes: 0 additions & 19 deletions src/Telescope-Core/TLMemorizeNodePositionAction.class.st
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions src/Telescope-Demo/TLDemos.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,22 +488,6 @@ TLDemos class >> exampleLineStyle [
^ visualization
]

{ #category : #demos }
TLDemos class >> exampleMovingNodeChangeEntity [
<script: 'self exampleMovingNodeChangeEntity open'>
<tlFilter: #interaction>
| visu |
visu := TLVisualization fromEntities: ((1 to: 5) collect: [ :i | (i * 20) @ (i * 20) ]).
visu
addInteractions:
{(TLCustomWithParameterAction block: [ :node :position | node entity: position x asInteger @ position y asInteger ]) onMove.
TLMemorizeNodePositionAction onMove}.
visu styleSheet
nodeLabel: #asString position: #top;
labelSize: 8.
^ visu
]

{ #category : #demos }
TLDemos class >> exampleMovingNodeToAnotherGroup [
<script: 'self exampleMovingNodeToAnotherGroup open'>
Expand Down