Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: QemuDisk-WWN #270

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

Tinyblargon
Copy link
Collaborator

Work done this PR

  • Added wwn property.
  • Added validate function to check if a wwn is valid.
  • Added unit tests.

Due to spacing changes in structs and test cases needed for a regex the change looks much bigger than it actually is.

Added this feature so Telmate/terraform-provider-proxmox#794 won't drop support for wwn option.

@Tinyblargon
Copy link
Collaborator Author

I'll rebase this after #272 is merged.

@mleone87 mleone87 merged commit c672c5e into Telmate:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants