New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #286 #288

Merged

mleone87 merged 3 commits into Telmate:master from Tinyblargon:Fix#286

Dec 7, 2023

Collaborator

Tinyblargon commented Dec 7, 2023 •

edited

Loading

This should Fix #286

I've figured out what happened.

The code that was moved to ConfigQemu{}.mapToStruct() in c0f9785 was added back to NewConfigQemuFromApi(vmr *VmRef, client *Client), this commit 3cf7815 removes the duplicate code.
A regex wasn't properly escaped 1fe88e4.

Tinyblargon added 3 commits

December 7, 2023 17:04


          fix: code got reverted during pull request

3cf7815


          fix: use literal string

1fe88e4


          fix: error strings should not be capitalized (ST1005)

1164f40

mleone87 merged commit 31826f2 into Telmate:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet