Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix Pool setting results in error 400 #307

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[fix] Fix Pool setting results in error 400 #307

merged 2 commits into from
Jan 31, 2024

Conversation

mleone87
Copy link
Collaborator

No description provided.

@mleone87
Copy link
Collaborator Author

should fix #306

@mleone87 mleone87 marked this pull request as ready for review January 31, 2024 13:34
@mleone87
Copy link
Collaborator Author

The tests are lying! 🐛

@Tinyblargon
Copy link
Collaborator

@mleone87

We do update the pool there, so I'm not sure why that pool property is set. I think it's safe to remove the offending test cases.

_, err = client.UpdateVMPool(vmr, newConfig.Pool)
return

@mleone87
Copy link
Collaborator Author

@Tinyblargon 99% confident, waiting for your 👍

@Tinyblargon Tinyblargon linked an issue Jan 31, 2024 that may be closed by this pull request
@Tinyblargon
Copy link
Collaborator

@mleone87 tested it, guest got added to pool so everything works.

@mleone87 mleone87 merged commit 58f6bb5 into master Jan 31, 2024
1 check passed
@mleone87 mleone87 deleted the fix-306 branch January 31, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: error 400 when setting pool on a Qemu Guest
2 participants