Fixed static checks

Telmate · Dec 13, 2023 · abc6a82 · abc6a82
1 parent b9ae9ec
commit abc6a82
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/proxmox/resource_storage_iso.go b/proxmox/resource_storage_iso.go
@@ -70,7 +70,13 @@ func resourceStorageIsoCreate(d *schema.ResourceData, meta interface{}) error {
 
 	client := pconf.Client
 	file, err := os.CreateTemp("/tmp", fileName)
+	if err != nil {
+		return err
+	}
 	err = _downloadFile(url, file)
+	if err != nil {
+		return err
+	}
 	file.Seek(0, 0)
 	defer file.Close()
 	err = client.Upload(node, storage, isoContentType, fileName, file)
@@ -96,7 +102,7 @@ func _downloadFile(url string, file *os.File) error {
 	}
 	defer resp.Body.Close()
 	_, err = io.Copy(file, resp.Body)
-	return nil
+	return err
 }
 
 func resourceStorageIsoRead(d *schema.ResourceData, meta interface{}) error {

diff --git a/proxmox/resource_vm_qemu.go b/proxmox/resource_vm_qemu.go
@@ -1069,16 +1069,15 @@ func resourceVmQemuCreate(ctx context.Context, d *schema.ResourceData, meta inte
 
 	forceCreate := d.Get("force_create").(bool)
 
-	var targetNodes []string
 	targetNodesRaw := d.Get("target_nodes").([]interface{})
-	targetNodes = make([]string, len(targetNodesRaw))
+	var targetNodes = make([]string, len(targetNodesRaw))
 	for i, raw := range targetNodesRaw {
 		targetNodes[i] = raw.(string)
 	}
 
 	var targetNode string
 
-	if targetNodes == nil || len(targetNodes) == 0 {
+	if len(targetNodes) == 0 {
 		targetNode = d.Get("target_node").(string)
 	} else {
 		targetNode = targetNodes[rand.Intn(len(targetNodes))]
@@ -1668,14 +1667,13 @@ func resourceVmQemuRead(ctx context.Context, d *schema.ResourceData, meta interf
 
 	// loop through all virtual servers...?
 	var targetNodeVMR string = ""
-	var targetNodes []string
 	targetNodesRaw := d.Get("target_nodes").([]interface{})
-	targetNodes = make([]string, len(targetNodesRaw))
+	var targetNodes = make([]string, len(targetNodesRaw))
 	for i, raw := range targetNodesRaw {
 		targetNodes[i] = raw.(string)
 	}
 
-	if targetNodes == nil || len(targetNodes) == 0 {
+	if len(targetNodes) == 0 {
 		_, err = client.GetVmInfo(vmr)
 		if err != nil {
 			logger.Debug().Int("vmid", vmID).Err(err).Msg("failed to get vm info")
@@ -1694,7 +1692,6 @@ func resourceVmQemuRead(ctx context.Context, d *schema.ResourceData, meta interf
 			d.SetId(resourceId(vmr.Node(), "qemu", vmr.VmId()))
 			logger.Debug().Any("Setting node id to", d.Get(vmr.Node()))
 			targetNodeVMR = targetNode
-			break
 		}
 	}