Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provider insecure by default #1178

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: provider insecure by default #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ their HCL.
```hcl
provider "proxmox" {
pm_api_url = "https://proxmox-server01.example.com:8006/api2/json"
pm_tls_insecure = true # By default Proxmox Virtual Environment uses self-signed certificates.
}
```

Expand Down Expand Up @@ -105,7 +106,7 @@ The following arguments are supported in the provider block:
| `pm_api_token_id` | `PM_API_TOKEN_ID` | `string` | | This is an [API token](https://pve.proxmox.com/pve-docs/pveum-plain.html) you have previously created for a specific user. |
| `pm_api_token_secret` | `PM_API_TOKEN` | `string` | | **Sensitive** This uuid is only available when the token was initially created. |
| `pm_otp` | `PM_OTP` | `string` | | The 2FA OTP code. |
| `pm_tls_insecure` | | `bool` | `true` | Disable TLS verification while connecting to the proxmox server. |
| `pm_tls_insecure` | | `bool` | `false` | Disable TLS verification while connecting to the proxmox server. |
| `pm_parallel` | | `uint` | `1` | Allowed simultaneous Proxmox processes (e.g. creating resources). Setting this greater than 1 is currently not recommended when using dynamic guest id allocation. |
| `pm_log_enable` | | `bool` | `false` | Enable debug logging, see the section below for logging details. |
| `pm_log_levels` | | `map` | | A map of log sources and levels. |
Expand Down
2 changes: 1 addition & 1 deletion proxmox/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func Provider() *schema.Provider {
schemaPmTlsInsecure: {
Type: schema.TypeBool,
Optional: true,
DefaultFunc: schema.EnvDefaultFunc("PM_TLS_INSECURE", true), // we assume it's a lab!
DefaultFunc: schema.EnvDefaultFunc("PM_TLS_INSECURE", false), // we assume it's a production environment.
Description: "By default, every TLS connection is verified to be secure. This option allows terraform to proceed and operate on servers considered insecure. For example if you're connecting to a remote host and you do not have the CA cert that issued the proxmox api url's certificate.",
},
schemaPmHttpHeaders: {
Expand Down