feat: added unlink of disks when removing disk blocks #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an update, the provider will check for disks previously attached to the VM which has now been removed from the HCL. The provider unlinks and detaches the disks if the disks are no longer a part of the configuration.
|
@FredrickB merge or close? |
|
This can be closed. Sorry that I haven't been able to follow up on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Telmate/proxmox-api-go#279
During an update, the provider will check for
disks previously attached to the VM which has
now been removed from the HCL. The provider
unlinks and detaches the disks if the disks are
no longer a part of the configuration.