Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add protection property to the resource_vm_qemu #994

Merged

Conversation

xserrat
Copy link
Contributor

@xserrat xserrat commented Apr 24, 2024

Expose the protection property for the resource_vm_qemu already added in the API Telmate/proxmox-api-go#320.

@Tinyblargon Tinyblargon self-requested a review April 24, 2024 10:12
@Tinyblargon Tinyblargon self-assigned this Apr 24, 2024
@Tinyblargon
Copy link
Collaborator

@xserrat Thank you for adding this feature, I've tested it and it works as intended. However it's not possible to use terraform destroy when protection is true, I'll fix this upstream Telmate/proxmox-api-go#330.

@Tinyblargon Tinyblargon merged commit 67954af into Telmate:master Apr 24, 2024
1 check passed
@xserrat xserrat deleted the add-protection-property-in-resource-vm-qemu branch April 24, 2024 18:30
@xserrat
Copy link
Contributor Author

xserrat commented Apr 24, 2024

@xserrat Thank you for adding this feature, I've tested it and it works as intended. However it's not possible to use terraform destroy when protection is true, I'll fix this upstream Telmate/proxmox-api-go#330.

Great! I've just realised 😄 Thank you too for this great provider 👏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants