Generalized csv reader #22
Conversation
…h will not be used in determining edges
changed the csv header names updated write_to_csv to determine the headers for the csv file from the config.yml when it is writing to csv
Addressed comments about reading the config file once and also indentation issues
…st". also, deleted some irrelevant code. addressed line 177 issue. reassigned yaml_config variable on line 208 to be the output of yaml.full_load.
…ictionaries containing the key value pair of the column name and the corresponding value from the row. adds generate_column_key_value_pair function which creates the key value pair of the column name and the corresponding value from the row. adds check_enum_columns_input_valid function which checks whether input value is within the allowed values specified in the config.yml file. adds config.yml format of inputting enum column, special columns and text columns data
…csv_row and generate_row functions from models.py and write_to_csv function from angel.py to write data into new csv file in the same column order that the input csv file is in
…ns data to ensure they do not match other player’s data. improves on error handling message when there is invalid input for enum columns. removed house requirement code.
|
merge conflict |
|
Error value and column should be quoted |
|
ensure consistency between
|
|
do not commit .DS_store |
| @@ -1,14 +1,57 @@ | |||
| # These track the column number of each player attribute in playerlist.csv file | |||
| # Note that change in csv column order can be edited here. | |||
| player_attribute_index: | |||
| @@ -75,131 +78,186 @@ def read_csv(filename): | |||
| return person_list | |||
|
|
|||
|
|
|||
| def convert_to_player(row): | |||
| def generalized_convert_to_player(row, column_names_index_dict): | |||
There was a problem hiding this comment.
why does the name contain "generalized"? is there still a relevant non-generalized version?
| generate_column_key_value_pair(text_columns, row) + | ||
| generate_column_key_value_pair(enum_columns, row, check_enum_columns_input_valid)) | ||
|
|
||
| print("output is\n", player_data) |
There was a problem hiding this comment.
please comment out debugging print statements. Or set a global "debug" variable, and only print if debug is turned on
| def generate_column_key_value_pair(type_of_column, row, function=None): | ||
| output = [] | ||
| for column_name in type_of_column: | ||
| # obtains the value of passing the column_name as a key to the type of column |
| if function is not None: | ||
| valid = function(type_of_column, column_dict, row_input.strip().lower()) | ||
| if not valid: | ||
| # outputs the element of which person that is not within the valid range for that |
There was a problem hiding this comment.
Sorry, i'm really struggling to understand the comments here
| return Player(player_data) | ||
|
|
||
|
|
||
| def generate_column_key_value_pair(type_of_column, row, function=None): |
There was a problem hiding this comment.
I think "type_of_column" is an inappropriate name
| else: | ||
| row_input = row[column_dict['index']] | ||
| if function is not None: | ||
| valid = function(type_of_column, column_dict, row_input.strip().lower()) |
There was a problem hiding this comment.
row_input.strip().lower() is called multiple times; it can be abstracted
There was a problem hiding this comment.
I don't quite see why you need to pass check_enum_columns_input_valid as a parameter. It seems to be the only case where this parameter is ever used?
| output = [] | ||
| for column_name in type_of_column: | ||
| # obtains the value of passing the column_name as a key to the type of column | ||
| column_dict = type_of_column[column_name] |
There was a problem hiding this comment.
What is the type of column_dict? Please use a variable name that is reflective of it
|
|
||
| player_data = (generate_column_key_value_pair(special_columns, row) + | ||
| generate_column_key_value_pair(text_columns, row) + | ||
| generate_column_key_value_pair(enum_columns, row, check_enum_columns_input_valid)) |
There was a problem hiding this comment.
I don't see why you would handle the different kinds of columns using the same function. Why not have three separate functions?
- handle special
- handle text
- handle enum
No description provided.