Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): add NightMode & improve method of getting UI state #3411

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat(ios): add NightMode & improve method of getting UI state #3411

merged 3 commits into from
Jul 26, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Jul 25, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@wwwcg wwwcg requested a review from ozonelmy as a code owner July 25, 2023 13:15
@github-actions github-actions bot added framework: ios doc: example size: l Denotes a PR that changes 500-999 lines labels Jul 25, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 25, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

ozonelmy
ozonelmy previously approved these changes Jul 25, 2023
View reviewed changes
@hippy-service
Copy link

hippy-service bot commented Jul 25, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@wwwcg
feat(ios): add NightMode and improve method of getting UI state
7c554ad 
Affect NightMode, statusBarHeight and Orientation
@wwwcg wwwcg changed the title feat(ios): add NightMode and host GlobalEnvInfo feat(ios): add NightMode & improve method of getting UI state Jul 26, 2023
@hippy-service
Copy link

hippy-service bot commented Jul 26, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@wwwcg wwwcg enabled auto-merge (rebase) July 26, 2023 09:11
@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Jul 26, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) July 26, 2023 09:32
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jul 26, 2023
@hippy-actions hippy-actions bot merged commit b665228 into Tencent:master Jul 26, 2023
30 of 32 checks passed
zealotchen0 pushed a commit that referenced this pull request Aug 7, 2023
@wwwcg @open-hippy @zealotchen0
feat(ios): add NightMode & improve method of getting UI state (#3411)
4a6d4de 
* chore(ios): eliminate some warnings

* feat(ios): add NightMode and improve method of getting UI state

Affect NightMode, statusBarHeight and Orientation

---------

Co-authored-by: OpenHippy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozonelmy ozonelmy ozonelmy approved these changes

Assignees
No one assigned
Labels
doc: example framework: ios size: l Denotes a PR that changes 500-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wwwcg @ozonelmy @zealotchen0 @open-hippy