Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(voltron): fix voltron http request dio null error #3962

Merged
merged 11 commits into from
Jul 24, 2024
Merged

fix(voltron): fix voltron http request dio null error #3962

merged 11 commits into from
Jul 24, 2024

Conversation

lvfen
Copy link
Collaborator

@lvfen lvfen commented Jul 23, 2024

fix voltron http request dio null error

@lvfen lvfen requested a review from henryjin0511 as a code owner July 23, 2024 04:38
@github-actions github-actions bot added framework: voltron size: xs Denotes a PR that changes 0-9 lines labels Jul 23, 2024
@tencent-adm
Copy link
Member

tencent-adm commented Jul 23, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lvfen
❌ open-hippy
You have signed the CLA already but the status is still pending? Let us recheck it.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Jul 23, 2024

Hi, @lvfen. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@lvfen
Merge branch 'fix/fix_voltron_remote_server_url_parse' into fix/fix_v…
1dbb63c 
…oltron_http_dio_null

# Conflicts:
#	framework/voltron/CHANGELOG.md
#	framework/voltron/pubspec.yaml
@lvfen
fix(voltron): fix voltron http request dio null error
c0f936d
@github-actions github-actions bot added size: s Denotes a PR that changes 10-99 lines and removed size: xs Denotes a PR that changes 0-9 lines labels Jul 23, 2024
@henryjin0511 henryjin0511 enabled auto-merge (squash) July 23, 2024 06:17
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jul 23, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@zealotchen0 zealotchen0 merged commit fa4120a into Tencent:main Jul 24, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryjin0511 henryjin0511 henryjin0511 approved these changes

Assignees
No one assigned
Labels
framework: voltron size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lvfen @tencent-adm @henryjin0511 @zealotchen0 @open-hippy