Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faces menu to Gradio py, plus slight increases to teh resolutions offered. I demonstrated teh improvements in model output in teh other pull request (that one is a dud, i did it right here) #79

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

NoviceArtisan
Copy link
Contributor

@NoviceArtisan NoviceArtisan commented Feb 4, 2025

Add faces control to Gradio.py app

As you mentioned, it's better to have it in the gradio app then done in the postprocessor file, I think these changes are correct, or near to. On my test install it does show the faces slider, moved up/down in 1k increments, with a min/max from 20k to 150k, and as shown in the other pull, give dramatic improvements.

I've also added a few extra options to the octree resolution, 768 and 1024, as they do make a noticable difference in high quality image output too, but again, make it take longer to process (still doable on 6gb vram tho!) Beyond that is past my patience to experiment with on my 6gb vram card las the processign times get a bit extreme lol (like more than an hour!)

[main](https://github.com/NoviceArtisan/Hunyuan3D-2) ([#1](https://github.com/NoviceArtisan/Hunyuan3D-2/pull/1))

As you mentioned, it's better to have it in the gradio app then done in teh postprocessor file, I think these changes are correct, or near too. On my test install it does show the faces slider, moved up/down in 1k increments, with a min/max from 20k to 150k.

I've also added a few extra options to the octree resolution, 769 and 1024, as they do make a noticable difference in high quality image output, but again, make it take longer to process (still doable on 6gb vram tho!)
@FurkanGozukara
Copy link

good work

@M0fD
Copy link

M0fD commented Feb 5, 2025

I implemented it earlier before I saw your post. I can confirm that you can even push it to 200000 with no problems

@NoviceArtisan
Copy link
Contributor Author

I implemented it earlier before I saw your post. I can confirm that you can even push it to 200000 with no problems

I found diminishing returns over 150k, as the models set to work from 200k and downscale to the 40k by default. I need to probe more into the initial mesh generation scrips than the postprocessor to investigate the process and modify it for the gradio users who do 3d printing. That sort of things doable much easier in ComfyUI, and porting controls to Gradio is more difficult.

If the owners permit this change to the base repo, i'll focus on making and sharing further mods for the gradio peeps

@Zeqiang-Lai Zeqiang-Lai merged commit 9da0051 into Tencent:main Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants