Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyright notes #29

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix copyright notes #29

wants to merge 10 commits into from

Conversation

iseri-nina
Copy link

@iseri-nina iseri-nina commented Jun 30, 2024

This PR will resolve issue #19: Fix copyright notes.

@heliang666s
Copy link

heliang666s commented Jun 30, 2024

#20 老哥你把我issue的内容做了。#19 难道不是增加缺失的逗号?

@iseri-nina
Copy link
Author

iseri-nina commented Jun 30, 2024

#20 老哥你把我issue的内容做了。#19 难道不是增加缺失的逗号?

我看 #19 的要求里“年份之后缺少逗号”只是个举例,也没具体指定是什么问题

翻遍了也没找到漏逗号的,这里改的那部分似乎也能算是 copyright notes 里的,于是就提交了 PR

@iseri-nina iseri-nina changed the title fix: Removed extra spaces from the copyright notes in the LICENSE file fix: Add missing comma Jun 30, 2024
@johnshajiang
Copy link
Collaborator

另外,请问你是否已经签属了Tencent Contributor License Agreement

@johnshajiang
Copy link
Collaborator

@iseri-nina
非常感谢你的修改。
我已经快速浏览了你的文件,后续还会仔细看看。

另外,如果PR没有问题,即便这个patch没有合并到Kona JDK中,依然可以认为你完成了这个的issue。

@johnshajiang
Copy link
Collaborator

@iseri-nina
当一个文件被修改之后,它的版本声明中的年份也需要相应的更新。
比如,原有的Copyright (C) 2021 THL A29 Limited需要修改为Copyright (C) 2021, 2024, THL A29 Limited

@iseri-nina
Copy link
Author

@johnshajiang

Copyright (C) 2020, 2022, THL A29 Limited, a Tencent company. All rights reserved.
对于这一类已经存在多个年份的版本声明,是修改成
Copyright (C) 2020, 2024, THL A29 Limited, a Tencent company. All rights reserved.
还是
Copyright (C) 2020, 2022, 2024, THL A29 Limited, a Tencent company. All rights reserved.

谢谢

@johnshajiang
Copy link
Collaborator

年份最多就两个,即起始年份和结束年份,所以是写成如下形式,
Copyright (C) 2020, 2024, THL A29 Limited

@johnshajiang johnshajiang changed the title fix: Add missing comma Fix copyright notes Jul 8, 2024
@iseri-nina
Copy link
Author

好的,已完成修改

@johnshajiang
Copy link
Collaborator

johnshajiang commented Jul 9, 2024

@iseri-nina
非常感谢你的更新。
这个补丁对于我来说,应该没有问题。

不过,考虑到有很多文件也存在于OpenJDK中,所以我们需要在未来逐步地处理它们。
但我们依然认为你完成了该issue,已经在研学基地中更新它的状态,请查看。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants