Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:Cherry Markdown : 竞品分析,markdown语法完善,设计异步hook #887

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Moqizhongyuan
Copy link

这个修复了cherryconfig中和之前快捷键冲突的问题,让cherryconfig中配置的快捷键可用,但是回导致原本默认快捷键无法使用

@sunsonliu
Copy link
Collaborator

感谢贡献,不过我们目前正在优化这里的快捷键配置问题,打算这么搞(如下)
image

还在搞哈,等搞完了欢迎体验~

@tencent-adm
Copy link
Member

tencent-adm commented Sep 5, 2024

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zhongyuan Yu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Moqizhongyuan
Copy link
Author

修复了一些commonmark的bug,autolink匹配的时候不会匹配到任意url,而是先校验是否被<>包裹,修改了localhost的匹配逻辑,可以正确匹配localhost,将address中匹配的特殊字符还原,让特殊符号正确被返回

@Moqizhongyuan Moqizhongyuan changed the title repair shortcutKey docs:Cherry Markdown : 竞品分析,markdown语法完善,设计异步hook Oct 10, 2024
@Moqizhongyuan
Copy link
Author

这几次提交修复了之前因为错误修改正则匹配规则导致的ReDos问题,使得页面可以正常渲染,同时commonmark的测试用例通过数量增加到了231,比最开始增加了18个,这其中修复了关于两端错误空格符的残留,修复了autolink关于链接的匹配,等等,同时还完成了竞品分析文档,采用markdown文件的形式展示,与marked.js产品进行比对分析,最后设计了一个initMath的异步函数,使得在运行configureMathJax(plugins)能异步进行,增加页面渲染速度,提升用户体验

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants