Add thread safety checks for PAGView and PAGImageView. #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingpqi123
requested review from
domchen,
Hparty and
shlzxjp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
+ Coverage 77.33% 77.38% +0.04%
==========================================
Files 420 420
Lines 22460 22460
Branches 6356 6359 +3
==========================================
+ Hits 17370 17380 +10
- Misses 3819 3821 +2
+ Partials 1271 1259 -12 ☔ View full report in Codecov by Sentry. |
domchen
reviewed
Nov 7, 2024
| @@ -262,14 +270,17 @@ - (BOOL)updateImageViewFrom:(CVPixelBufferRef)pixelBuffer atIndex:(NSInteger)fra | |||
| self.currentUIImage = image; | |||
| [self submitToImageView]; | |||
| } | |||
| if ([imagesMap count] == (NSUInteger)[[self getPAGDecoder] numFrames]) { | |||
| if ([imagesMap count] == numFrames) { | |||
There was a problem hiding this comment.
你这里还没执行updatePAGDecoder, numFrames可能是0吧？检查一下其他相关的逻辑
There was a problem hiding this comment.
如果 pagDeocder 为空，走不这里
domchen
changed the title
domchen
approved these changes
Nov 7, 2024
Hparty
pushed a commit
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 832d86c)
kevingpqi123
added a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 832d86c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.