fix: the polaris config relation non-daemon thread should stop when application fails to start. #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication fails to start.
shuiqingliu
force-pushed
the
feature-long-pulling-thread-stop
branch
from
351edf3 to
1035b9c
Compare
shuiqingliu
changed the title
Codecov Report
@@ Coverage Diff @@
## 2021.0 #1100 +/- ##
============================================
- Coverage 81.41% 81.20% -0.22%
- Complexity 1675 1683 +8
============================================
Files 251 252 +1
Lines 5683 5729 +46
Branches 662 674 +12
============================================
+ Hits 4627 4652 +25
- Misses 678 688 +10
- Partials 378 389 +11
|
SkyeBeFreeman
force-pushed
the
2021.0
branch
from
7fa8b7b to
5973cad
Compare
...java/com/tencent/cloud/polaris/config/listener/PolarisConfigNonDaemonThreadStopListener.java
Outdated
Show resolved
Hide resolved
if we register a destroy hook for RemoteConfigFileRepo on the class instance , the static thread pool may be terminated by the bootstrap context closing ,Therefore,it's better to register the destroy hook when the application is prepared, or when the application fails to start, in order to properly destroy resources
…gliu/spring-cloud-tencent into feature-long-pulling-thread-stop
…gliu/spring-cloud-tencent into feature-long-pulling-thread-stop
SkyeBeFreeman
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Bugfix
Describe what this PR does for and how you did.
the polaris config relation non-daemon thread should stop when application fails to start.
Adding the issue link (#xxx) if possible.
#1032
Note
Checklist
Checklist (Optional)